Re: [PATCH] ASoC: dt-bindings: Drop broken irondevice, sma1303 binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Wed, Feb 01, 2023 at 03:43:12PM +0100, Krzysztof Kozlowski wrote:
> 
> > I tried. I started writing patch to fix few things in this binding and
> > then noticed that it is entirely empty and documents nothing.
> 
> I really don't see an empty binding as a major problem in and of itself,
> we can always add properties later.  Again, I can't tell what the problems
> you're seeing are.
> 
> > The trouble is that soon you will send it to Linus and then it becomes
> > the ABI even though no one ever approved or reviewed the actual ABI.
> 
> So send a patch to delete the property parsing code then, like I say
> removing the entire driver is very much an overraction.  The properties are
> all optional in the code.

Ok. I'm sorry for not checking correctly.
I only reviewed using the full source build and checkpatch.pl.
But I missed the config setting...

So, could I get the information how to test the binding files?
>From what I've checked now, using make dt_binding_check, right?

I'll try to read again like submitting-patches.rst and writing-bindings.rst.
And then re-write the patch. I'm sorry again for not checking properly.


Thanks Mark and Krzysztof to feedback.

Best Regards,
Kiseok Jo

Attachment: signature.asc
Description: signature.asc


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux