Hi Mohammad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on broonie-sound/for-next] [also build test WARNING on next-20230201] [cannot apply to tiwai-sound/for-next tiwai-sound/for-linus linus/master v6.2-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Mohammad-Rafi-Shaik/ALSA-compress-Update-compress-set-params-for-gapless-playback/20230201-215622 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20230201134947.1638197-11-quic_mohs%40quicinc.com patch subject: [PATCH 10/14] ASoC: q6dsp: q6apm-dai: Add trigger/pointer compress DAI callbacks config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230202/202302020014.J221iZHe-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/2b44c079fb2d53ef9e13fc7d7b257fd4c6f4b56a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mohammad-Rafi-Shaik/ALSA-compress-Update-compress-set-params-for-gapless-playback/20230201-215622 git checkout 2b44c079fb2d53ef9e13fc7d7b257fd4c6f4b56a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash sound/soc/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): sound/soc/qcom/qdsp6/q6apm-dai.c:152:6: warning: no previous prototype for 'event_handler_compr' [-Wmissing-prototypes] 152 | void event_handler_compr(uint32_t opcode, uint32_t token, | ^~~~~~~~~~~~~~~~~~~ >> sound/soc/qcom/qdsp6/q6apm-dai.c:576:5: warning: no previous prototype for 'q6apm_dai_compr_trigger' [-Wmissing-prototypes] 576 | int q6apm_dai_compr_trigger(struct snd_soc_component *component, | ^~~~~~~~~~~~~~~~~~~~~~~ >> sound/soc/qcom/qdsp6/q6apm-dai.c:610:5: warning: no previous prototype for 'q6apm_dai_compr_ack' [-Wmissing-prototypes] 610 | int q6apm_dai_compr_ack(struct snd_soc_component *component, struct snd_compr_stream *stream, | ^~~~~~~~~~~~~~~~~~~ vim +/q6apm_dai_compr_trigger +576 sound/soc/qcom/qdsp6/q6apm-dai.c 575 > 576 int q6apm_dai_compr_trigger(struct snd_soc_component *component, 577 struct snd_compr_stream *stream, int cmd) 578 { 579 struct snd_compr_runtime *runtime = stream->runtime; 580 struct q6apm_dai_rtd *prtd = runtime->private_data; 581 int ret = 0; 582 583 switch (cmd) { 584 case SNDRV_PCM_TRIGGER_START: 585 case SNDRV_PCM_TRIGGER_RESUME: 586 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 587 ret = q6apm_write_async_compr(prtd->graph, prtd->pcm_count, 0, 0, NO_TIMESTAMP); 588 break; 589 case SNDRV_PCM_TRIGGER_STOP: 590 break; 591 case SNDRV_PCM_TRIGGER_SUSPEND: 592 case SNDRV_PCM_TRIGGER_PAUSE_PUSH: 593 break; 594 case SND_COMPR_TRIGGER_NEXT_TRACK: 595 prtd->next_track = true; 596 prtd->next_track_stream_id = (prtd->graph->id == 1 ? 2 : 1); 597 break; 598 case SND_COMPR_TRIGGER_DRAIN: 599 case SND_COMPR_TRIGGER_PARTIAL_DRAIN: 600 prtd->notify_on_drain = true; 601 break; 602 default: 603 ret = -EINVAL; 604 break; 605 } 606 607 return ret; 608 } 609 > 610 int q6apm_dai_compr_ack(struct snd_soc_component *component, struct snd_compr_stream *stream, 611 size_t count) 612 { 613 struct snd_compr_runtime *runtime = stream->runtime; 614 struct q6apm_dai_rtd *prtd = runtime->private_data; 615 unsigned long flags; 616 617 spin_lock_irqsave(&prtd->lock, flags); 618 prtd->bytes_received += count; 619 spin_unlock_irqrestore(&prtd->lock, flags); 620 621 return count; 622 } 623 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
