On 30/01/2023 12:01, Venkata Prasad Potturu wrote:
> Refactor bit width calculation using params_physical_width()
> instead hard-code values.
I would have added a Reported-by tag for Pierre...
A Fixes tag might also help this patch to follow
ca9d237994db ("ASoC: amd: acp: Refactor i2s clocks programming sequence")
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>
> Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu@xxxxxxx>
> ---
> sound/soc/amd/acp/acp-mach-common.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c
> index b83ae946b3e4..b4dcce4fbae9 100644
> --- a/sound/soc/amd/acp/acp-mach-common.c
> +++ b/sound/soc/amd/acp/acp-mach-common.c
> @@ -186,7 +186,7 @@ static int acp_card_rt5682_hw_params(struct snd_pcm_substream *substream,
>
> srate = params_rate(params);
> ch = params_channels(params);
> - format = 8 * params_format(params);
> + format = params_physical_width(params);
>
> if (drvdata->tdm_mode)
> fmt = SND_SOC_DAIFMT_DSP_A;
> @@ -330,7 +330,7 @@ static int acp_card_rt5682s_hw_params(struct snd_pcm_substream *substream,
>
> srate = params_rate(params);
> ch = params_channels(params);
> - format = 8 * params_format(params);
> + format = params_physical_width(params);
>
> if (drvdata->tdm_mode)
> fmt = SND_SOC_DAIFMT_DSP_A;
> @@ -475,7 +475,7 @@ static int acp_card_rt1019_hw_params(struct snd_pcm_substream *substream,
>
> srate = params_rate(params);
> ch = params_channels(params);
> - format = 8 * params_format(params);
> + format = params_physical_width(params);
>
> if (drvdata->amp_codec_id != RT1019)
> return -EINVAL;
> @@ -616,7 +616,7 @@ static int acp_card_maxim_hw_params(struct snd_pcm_substream *substream,
>
> srate = params_rate(params);
> ch = params_channels(params);
> - format = 8 * params_format(params);
> + format = params_physical_width(params);
>
> if (drvdata->tdm_mode)
> fmt = SND_SOC_DAIFMT_DSP_A;
--
Péter
