On 20/01/2023 10:50, Herve Codina wrote: > The Renesas IDT821034 codec is a quad PCM codec with programmable > gain. > > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx> > --- Thank you for your patch. There is something to discuss/improve. > + gpio-controller: true > + > +required: > + - compatible > + - reg > + - spi-cpha > + - '#sound-dai-cells' > + - gpio-controller > + - '#gpio-cells' > + > +unevaluatedProperties: false > + > +examples: > + - | > + spi0 { I didn't notice it earlier - this should be just "spi". With above: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof