At Tue, 01 Jul 2008 03:36:00 +1000, Travis Place wrote: > > I think i was a bit quick/excited about getting this info in > there..Tested on my 2 machines here (both running 2.6.24 though) without > issues.. Will have to look into it further (after taking your advice) > and rework this patch. > > On Mon, 2008-06-30 at 17:42 +0100, Mark Brown wrote: > > On Tue, Jul 01, 2008 at 02:31:37AM +1000, Travis Place wrote: > > > > > +if [ -d $SYSFS ] > > > +then > > > +BOARD_VENDOR=`cat /sys/devices/virtual/dmi/id/board_vendor` > > > +PRODUCT_VERSION=`cat /sys/devices/virtual/dmi/id/product_version` > > > +PRODUCT_NAME=`cat /sys/devices/virtual/dmi/id/product_name` > > > > This produces visible errors if the information isn't present (which > > would be reasonable enough). It might be better to check for errors and > > include something about being unable to read DMI information in the > > report - that'd be a bit less scary. > > > > Also, on my system the DMI information is under /sys/class/dmi rather > > than /sys/devices/virtual (this is with 2.6.25). > > This will certainly be a pain, if the info keep moving around.. unless > we do some quick 'search' for the 'dmi' dir. Well, just keeping a couple of possible places and checking each direcory should suffice instead of just checking /sys. > > > > > +fi > > > > How about bios_vendor, bios_date and bios_version as well? > > > How useful is the BIOS information going to be, in most cases ? It'd be helpful if a certain BIOS version is known to be broken. Or, for comparing two devices, one working and one not-working. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
