Re: [PATCH] ALSA: pcm: Move rwsem lock inside snd_ctl_elem_read to prevent UAF

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13. 01. 23 13:07, Takashi Iwai wrote:
From: Clement Lecigne <clecigne@xxxxxxxxxx>

Takes rwsem lock inside snd_ctl_elem_read instead of snd_ctl_elem_read_user
like it was done for write in commit 1fa4445f9adf1 ("ALSA: control - introduce
snd_ctl_notify_one() helper"). Doing this way we are also fixing the following
locking issue happening in the compat path which can be easily triggered and
turned into an use-after-free.

64-bits:
snd_ctl_ioctl
   snd_ctl_elem_read_user
     [takes controls_rwsem]
     snd_ctl_elem_read [lock properly held, all good]
     [drops controls_rwsem]

32-bits:
snd_ctl_ioctl_compat
   snd_ctl_elem_write_read_compat
     ctl_elem_write_read
       snd_ctl_elem_read [missing lock, not good]

CVE-2023-0266 was assigned for this issue.

Cc: stable@xxxxxxxxxx # 5.13+
Signed-off-by: Clement Lecigne <clecigne@xxxxxxxxxx>
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>

Reviewed-by: Jaroslav Kysela <perex@xxxxxxxx>

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux