On 11/01/23 19:06, Pierre-Louis Bossart wrote: > > On 1/11/23 03:02, Vijendar Mukunda wrote: >> Pink Sardine(ps) platform is based on ACP6.3 Architecture. >> ACP6.3 IP has two soundwire controller instance support. > After reviewing patch1, it looks like there's a confusion between > controller and manager? the use of the 'sdw-master-count' property is > not for controller count, it's defined within the scope of an ACPI > controller device (usually a companion device to the PCI device). Sorry for confusion. We are meant to refer Master/Manager instance in throughout the code. we will replace the "Controller" reference with "Manager". We will correct the cover letter. >> This patchset add support for Soundwire controller on Pink Sardine >> platform. > That's great, thanks for sharing. > >> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@xxxxxxx> >> Vijendar Mukunda (19): >> ASoC: amd: ps: create platform devices based on acp config >> soundwire: amd: Add support for AMD Master driver >> soundwire: amd: register sdw controller dai ops >> soundwire: amd: enable build for AMD soundwire master driver >> soundwire: amd: add soundwire interrupt handling >> ASoC: amd: ps: add support for soundwire interrupts in acp pci driver >> ASoC: amd: ps: add soundwire dma driver for pink sardine platform >> ASoC: amd: ps: add soundwire dma driver dma ops >> ASoC: amd: ps: add support for Soundwire DMA interrupts >> ASoC: amd: ps: enable Soundwire DMA driver build >> ASoC: amd: update comments in Kconfig file >> ASoC: amd: ps: Add soundwire specific checks in pci driver in pm ops. >> ASoC: amd: ps: add support for runtime pm ops for soundwire dma driver >> soundwire: amd: add runtime pm ops for AMD master driver >> soundwire: amd: add startup and shutdown dai ops >> soundwire: amd: handle wake enable interrupt >> soundwire: amd: add pm_prepare callback and pm ops support >> ASoC: amd: ps: implement system level pm ops for soundwire dma driver >> ASoC: amd: ps: increase runtime suspend delay >> >> drivers/soundwire/Kconfig | 9 + >> drivers/soundwire/Makefile | 4 + >> drivers/soundwire/amd_master.c | 1734 +++++++++++++++++++++++++++++ >> drivers/soundwire/amd_master.h | 284 +++++ >> include/linux/soundwire/sdw_amd.h | 65 ++ >> sound/soc/amd/Kconfig | 3 +- >> sound/soc/amd/ps/Makefile | 2 + >> sound/soc/amd/ps/acp63.h | 98 +- >> sound/soc/amd/ps/pci-ps.c | 383 ++++++- >> sound/soc/amd/ps/ps-sdw-dma.c | 728 ++++++++++++ >> 10 files changed, 3287 insertions(+), 23 deletions(-) >> create mode 100644 drivers/soundwire/amd_master.c >> create mode 100644 drivers/soundwire/amd_master.h >> create mode 100644 include/linux/soundwire/sdw_amd.h >> create mode 100644 sound/soc/amd/ps/ps-sdw-dma.c >>
