Re: [PATCH] ASoC: dt-bindings: simple-card: Document simple-audio-card,plat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

On 1/8/2023 10:07 PM, Rob Herring wrote:
> On Thu, Jan 05, 2023 at 09:33:46PM +0530, Faiz Abbas wrote:
>> The simple card driver has support for adding cpu, codec and platform
>> nodes with the simple-audio-card prefix. Add documentation for the plat
>> binding.
> Another node, is it still 'simple card'?

This behavior already exists in the driver. I am just documenting what already exists.

>> Signed-off-by: Faiz Abbas <faiz.abbas@xxxxxxx>
>> ---
>>  .../bindings/sound/simple-card.yaml           | 23 +++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml
>> index ed19899bc94b..fa67c76d4dbb 100644
>> --- a/Documentation/devicetree/bindings/sound/simple-card.yaml
>> +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml
>> @@ -205,6 +205,8 @@ patternProperties:
>>      $ref: "#/definitions/dai"
>>    "^simple-audio-card,codec(@[0-9a-f]+)?$":
>>      $ref: "#/definitions/dai"
>> +  "^simple-audio-card,plat(@[0-9a-f]+)?$":
> What does 'plat' mean?

plat means platform. I'll make that clear in the patch description in v2.


> Don't continue the 'simple-audio-card,' prefix.

The implementation already exists. Its just not documented here.


>> +    $ref: "#/definitions/dai"
>>
>>    "^simple-audio-card,dai-link(@[0-9a-f]+)?$":
>>      description: |
>> @@ -285,6 +287,27 @@ examples:
>>          };
>>      };
>>
>> +#-------------------------------
>> +# single DAI link with platform
>> +#-------------------------------
> Really need another example for 1 simple node?

I'll remove the example if that makes it easier.

Thanks,

Faiz

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux