RE: [PATCH 04/14] Removed the usage control and add the power switch on DAPM route.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Fri, Jan 06, 2023 at 06:15:33PM +0900, Kiseok Jo wrote:
> > Signed-off-by: Kiseok Jo <kiseok.jo@xxxxxxxxxxxxxx>
> > Reported-by: Mark Brown <broonie@xxxxxxxxxx>
> > ---
> >  sound/soc/codecs/sma1303.c | 79 
> > ++++----------------------------------
> >  1 file changed, 8 insertions(+), 71 deletions(-)

> This and most of your other followup patches should be part of patch 1 - normally you shouldn't introduce problems then fix them as part of the same patch series, this makes it very hard to review things since people will see the problems earlier on and perhaps not get as far as seeing the fix.  Once the code is merged changes need to be incremental but until then you should fix the patch itself.

Thank you for your reply.

I misunderstood what you say. I haven't registered the new driver code on the kernel.
So I think it's not new patch. So I resend the mail updating patch version applied your feedback.
(Because this patch's topic is 'Add driver')

If the driver is registered and there are any changes, I'll make a new patch for each changes.
And the patches doesn't make same patch series.

I already resent the patch mail for registering a new driver, please check if there is a problem.

Thank you.

Best regards,
Kiseok Jo




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux