Re: [PATCH 1/2] ALSA: hda: cs35l41: Don't return -EINVAL from system suspend/resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 05 Jan 2023 11:14:13 +0100,
Thorsten Leemhuis wrote:
> 
> On 05.01.23 10:35, Takashi Iwai wrote:
> > The recent commit to support the system suspend for CS35L41 caused a
> > regression on the models with CS35L41_EXT_BOOST_NO_VSPK_SWITC boost
> > type, as the suspend/resume callbacks just return -EINVAL.  This is
> > eventually handled as a fatal error and blocks the whole system
> > suspend/resume.
> > 
> > For avoiding the problem, this patch corrects the return code from
> > cs35l41_system_suspend() and _resume() to 0, and replace dev_err()
> > with dev_err_once() for stop spamming too much.
> > 
> > Fixes: 88672826e2a4 ("ALSA: hda: cs35l41: Support System Suspend")
> > Cc: <stable@xxxxxxxxxxxxxxx>
> 
> Thx for taking care of that.
> 
> > Link: https://lore.kernel.org/r/4262e3c4-6169-bbd2-e918-16b06f6994bc@xxxxxxxxxxxxxx
> 
> Lore says "Not found". I wonder if it was a private mail later send
> again here:
> 
> https://lore.kernel.org/all/e6751ac2-34f3-d13f-13db-8174fade8308@xxxxx/

Yeah, it looks so.  I'll correct the URL at applying the patches.


thanks,

Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux