On 03/01/2023 12:27, wangweidong.a@xxxxxxxxxx wrote: > Hi Krzysztof > > On 30/12/2022 10:34, wangweidong.a@xxxxxxxxxx wrote: >>> From: Weidong Wang <wangweidong.a@xxxxxxxxxx> >>> >>> Add a DT schema for describing Awinic AW883xx audio amplifiers. They are >>> controlled using I2C. >>> >>> Signed-off-by: Weidong Wang <wangweidong.a@xxxxxxxxxx> >>> --- >>> .../bindings/sound/awinic,aw883xx.yaml | 49 +++++++++++++++++++ >>> 1 file changed, 49 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml >>> new file mode 100644 >>> index 000000000000..b677427ebcd1 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/sound/awinic,aw883xx.yaml >>> @@ -0,0 +1,49 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/sound/awinic,aw883xx.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Awinic AW883xx Smart Audio Amplifier >>> + >>> +maintainers: >>> + - Stephan Weidong Wang <wangweidong.a@xxxxxxxxxx> >>> + >>> +description: >>> + The Awinic AW883XX is an I2S/TDM input, high efficiency >>> + digital Smart K audio amplifier with an integrated 10.25V >>> + smart boost convert. >>> + >>> +allOf: >>> + - $ref: dai-common.yaml# >>> + >>> +properties: >>> + compatible: >>> + const: awinic,aw883xx > >> Now the question what does "xx" stand for? I cannot find such product on >> awinic website: >> https://www.awinic.com/En/Index/queryAll/wd/aw883xx.html > > xx represents our company's aw88394 and aw88395 chips,Aw88395 chips can be found on > https://www.awinic.com/cn/detail/index/catid/229/id/48/title/AW88395CSR.html > The aw88394 chip will be available on the website in the near future. OK, then it has to be changed. Wildcards are not allowed in compatibles, so please use a specific compatible (oneOf for a case specific compatible alone and for a case of two compatibles with fallback; assuming the fallback is applicable to others). Best regards, Krzysztof
