Forwarding to the ALSA ML. ----- Forwarded message from bugzilla-daemon@xxxxxxxxxx ----- Date: Thu, 29 Dec 2022 10:07:51 +0000 From: bugzilla-daemon@xxxxxxxxxx To: bp@xxxxxxxxx Subject: [Bug 216861] New: sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157 Message-ID: <bug-216861-6385@xxxxxxxxxxxxxxxxxxxxxxxxx/> https://bugzilla.kernel.org/show_bug.cgi?id=216861 URL: https://bugzilla.altlinux.org/44690 Bug ID: 216861 Summary: sound disappearance on Acer Swift 3 SF314-59-78UR after update to 5.10.157 Product: Platform Specific/Hardware Version: 2.5 Kernel Version: 5.10.157 Hardware: Intel OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: x86-64 Assignee: platform_x86_64@xxxxxxxxxxxxxxxxxxxx Reporter: zagagyka@xxxxxxxxxx CC: broonie@xxxxxxxxxx, perex@xxxxxxxx Regression: Yes Created attachment 303497 --> https://bugzilla.kernel.org/attachment.cgi?id=303497&action=edit pulseaudio.log Sudden sound disappearance was reported for some laptops, e.g. Acer Swift 3 SF314-59-78UR 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz # lspci 0000:00:1f.3 Multimedia audio controller: Intel Corporation Tiger Lake-LP Smart Sound Technology Audio Controller (rev 20) Subsystem: Acer Incorporated [ALI] Device 148c Flags: bus master, fast devsel, latency 32, IRQ 197, IOMMU group 12 Memory at 601f270000 (64-bit, non-prefetchable) [size=16K] Memory at 601f000000 (64-bit, non-prefetchable) [size=1M] Capabilities: [50] Power Management version 3 Capabilities: [80] Vendor Specific Information: Len=14 <?> Capabilities: [60] MSI: Enable+ Count=1/1 Maskable- 64bit+ Kernel driver in use: sof-audio-pci I am attaching the pulseaudio and dmesg logs This bug started reproducing after updating the kernel from 5.10.156 to 5.10.157 Bisection revealed the commit being reverted: c34db0d6b88b1da95e7ab3353e674f4f574cccee is the first bad commit commit c34db0d6b88b1da95e7ab3353e674f4f574cccee Author: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx> Date: Fri Nov 4 13:22:13 2022 +0000 ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open() [ Upstream commit 39bd801d6908900e9ab0cdc2655150f95ddd4f1a ] The DAI tx_mask and rx_mask are set by snd_soc_dai_set_tdm_slot() and used by later code that depends on the TDM settings. So __soc_pcm_open() should not be obliterating those mask values. The code in __soc_pcm_hw_params() uses these masks to calculate the active channels so that only the AIF_IN/AIF_OUT widgets for the active TDM slots are enabled. The zeroing of the masks in __soc_pcm_open() disables this functionality so all AIF widgets were enabled even for channels that are not assigned to a TDM slot. Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx> Fixes: 2e5894d73789 ("ASoC: pcm: Add support for DAI multicodec") Link: https://lore.kernel.org/r/20221104132213.121847-1-rf@xxxxxxxxxxxxxxxxxxxxx Signed-off-by: Mark Brown <broonie@xxxxxxxxxx> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> sound/soc/soc-pcm.c | 5 ----- 1 file changed, 5 deletions(-) Original bug report: https://bugzilla.altlinux.org/44690 -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ----- End forwarded message ----- -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
