Re: [PATCH v3] dt-bindings: sound: tlv320aic3x: Convert to dtschema

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 20/12/2022 13:39, Jai Luthra wrote:
> Convert bindings for TI's TLV320AIC3x audio codecs to dtschema.
> 
> The following properties are still found in some old dts files, but will
> be ignored by the driver:
> - adc-settle-ms
> - assigned-clock-paranets, assigned-clock-rates, assigned-clocks
> - port
> 
> Signed-off-by: Jai Luthra <j-luthra@xxxxxx>
> ---

Thank you for your patch. There is something to discuss/improve.

> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      tlv320aic3x_i2c: tlv320aic3x@1b {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +        compatible = "ti,tlv320aic3x";
> +        reg = <0x1b>;
> +
> +        reset-gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
> +
> +        AVDD-supply = <&regulator>;
> +        IOVDD-supply = <&regulator>;
> +        DRVDD-supply = <&regulator>;
> +        DVDD-supply = <&regulator>;
> +      };
> +    };
> +
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      tlv320aic3x_spi: codec@0 {
> +        compatible = "ti,tlv320aic3x";
> +        reg = <0>; /* CS number */
> +        #sound-dai-cells = <0>;
> +
> +        AVDD-supply = <&regulator>;
> +        IOVDD-supply = <&regulator>;
> +        DRVDD-supply = <&regulator>;
> +        DVDD-supply = <&regulator>;
> +        ai3x-ocmv = <0>;
> +      };
> +    };
> +
> +...

Best regards,
Krzysztof