On Mon, Jun 23, 2008 at 12:54:07PM +0100, Ben Dooks wrote:
> Add SPI support to the WM8750 ASoC codec by splitting
> the I2C out of the WM8750 codec and adding an standard
> SPI driver to the system.
This looks good. My only substantial concern with it is that it means
that this driver isn't consistent with the other codec drivers since
there are now three modules built for it - one for the core and one for
each bus type. Would it be possible to integrate the SPI support into
the main WM8750 driver or are there substantial drawbacks from doing
that? The main thing is ending up loading SPI when it's not needed but
I'm not sure how big a cost that is or if there's anything else?
Also (very minor, but it'll get picked up on):
> -static int wm8750_suspend(struct platform_device *pdev, pm_message_t state)
> +int wm8750_suspend(struct platform_device *pdev, pm_message_t state)
> {
> struct snd_soc_device *socdev = platform_get_drvdata(pdev);
> struct snd_soc_codec *codec = socdev->codec;
> @@ -760,7 +759,9 @@ static int wm8750_suspend(struct platfor
> return 0;
> }
>
> -static int wm8750_resume(struct platform_device *pdev)
> +EXPORT_SYMBOL_GPL(wm8750_suspend);
checkpatch will want there to be no space between the function and the
EXPORT_SYMBOL_GPL() for it.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
