Re: [PATCH 06/11] ASoC: dt-bindings: ti, pcm3168a: Convert to json-schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Morimoto-san,

On Wed, Dec 14, 2022 at 2:23 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Convert the Texas Instruments PCM3168A Audio Codec Device Tree binding
> documentation to json-schema.
>
> Add missing properties.
> Drop unneeded pinctrl properties from example.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

Thanks for your patch!

You forgot to list the changes you made to my patch:
  - Refer to audio-graph-port.yaml instead of describing ports and
    port@[01] subnodes explicitly.

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
> @@ -0,0 +1,100 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/ti,pcm3168a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments PCM3168A Audio Codec
> +
> +maintainers:
> +  - Damien Horsley <Damien.Horsley@xxxxxxxxxx>

For v2, I had planned

    -+  - Damien Horsley <Damien.Horsley@xxxxxxxxxx>
    ++  - Jaroslav Kysela <perex@xxxxxxxx>
    ++  - Takashi Iwai <tiwai@xxxxxxxx>

as Damien's address bounces.

Or perhaps you want to become the maintainer?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux