On Wed, Dec 14, 2022 at 01:37:41PM +0100, Lukasz Majewski wrote: > Without this change, the wm8940 driver is not working when > set_sysclk callback (wm8940_set_dai_sysclk) is called with > frequency not listed in the switch clause. Your commit log doesn't actually describe what this change is... > This change adjusts this driver to allow non-standard frequency > set (just after the boot) being adjusted afterwards by the sound > system core code. This doesn't appear to correspond to the commit. The change will result in the driver automatically configuring it's PLL. > Code in this commit is based on previous change done for wm8974 > (SHA1: 51b2bb3f2568e6d9d81a001d38b8d70c2ba4af99). Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read. > @@ -496,7 +505,6 @@ static int wm8940_set_bias_level(struct snd_soc_component *component, > return ret; > } > } > - > /* ensure bufioen and biasen */ > pwr_reg |= (1 << 2) | (1 << 3); > /* set vmid to 300k for standby */ Unrelated (and questionable) whitespace change.
Attachment:
signature.asc
Description: PGP signature
