On 12/13/22 06:32, Hans de Goede wrote: > The Advantech MICA-071 tablet deviates from the defaults for > a non CR Bay Trail based tablet in several ways: > > 1. It uses an analog MIC on IN3 rather then using DMIC1 > 2. It only has 1 speaker > 3. It needs the OVCD current threshold to be set to 1500uA instead of > the default 2000uA to reliable differentiate between headphones vs > headsets > > Add a quirk with these settings for this tablet. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > --- > sound/soc/intel/boards/bytcr_rt5640.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c > index fb9d9e271845..ddd2625bed90 100644 > --- a/sound/soc/intel/boards/bytcr_rt5640.c > +++ b/sound/soc/intel/boards/bytcr_rt5640.c > @@ -570,6 +570,21 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { > BYT_RT5640_SSP0_AIF1 | > BYT_RT5640_MCLK_EN), > }, > + { > + /* Advantech MICA-071 */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Advantech"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MICA-071"), > + }, > + /* OVCD Th = 1500uA to reliable detect head-phones vs -set */ > + .driver_data = (void *)(BYT_RT5640_IN3_MAP | > + BYT_RT5640_JD_SRC_JD2_IN4N | > + BYT_RT5640_OVCD_TH_1500UA | > + BYT_RT5640_OVCD_SF_0P75 | > + BYT_RT5640_MONO_SPEAKER | > + BYT_RT5640_DIFF_MIC | > + BYT_RT5640_MCLK_EN), > + }, > { > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ARCHOS"),