Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

[Jiaxin Yu (俞家鑫) <Jiaxin.Yu@xxxxxxxxxxxx>]

On Mon, 2022-12-05 at 12:07 +0000, Mark Brown wrote:
> On Mon, Dec 05, 2022 at 09:34:17AM +0000, Jiaxin Yu (俞家鑫) wrote:
> 
> > 1. I have added a DAPM widget that is "SDB", when we open or close
> > HDMI
> > PIN_SWITCH, the callback 'hdmi_tx_event' registered in the widget
> > will
> > be triggered. Maybe you mean I shouldn't use
> > SNDRV_PCM_TRIGGER_START
> > and SNDRV_PCM_TRIGGER_STOP?
> 
> No, I mean that if you want to control the enable and disable of the
> output path you should implement a DAPM widget.
> 
May I ask which driver file to add a new DAPM widget? Is it the bridge
ic driver like it6505.c? Or is it linke the "SDB" added in this patch?

> > 2. If I don't use hcd.ops->trigger notifies the bridge ic driver to
> > switch the audio, which ops should I use?
> > I actually want to know hdmi-codec.c and it6505.c except
> > hdmi_codec_ops, is there any other way to communicate?
> 
> Like I said you should use the event on the DAPM widget.  This will
> require providing operations for the events to the drivers.
Yes, I should add a new set of events, such as:

enum {
    HDMI_CODEC_TRIGGER_EVENT_STOP,
    HDMI_CODEC_TRIGGER_EVENT_START,
    HDMI_CODEC_TRIGGER_EVENT_SUSPEND,
    HDMI_CODEC_TRIGGER_EVENT_RESUME,
}

Then provide handles for these events in the it6505 driver. Am I right?


Thanks,
Jiaxin.Yu