Re: [PATCH 2/2] ASoC: SOF: Revert: "core: unregister clients and machine drivers in .shutdown"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 09, 2022 at 01:45:29PM +0200, Kai Vehmanen wrote:

> This reverts commit 83bfc7e793b555291785136c3ae86abcdc046887.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

> -	/*
> -	 * make sure clients and machine driver(s) are unregistered to force
> -	 * all userspace devices to be closed prior to the DSP shutdown sequence
> -	 */
> -	sof_unregister_clients(sdev);
> -
> -	snd_sof_machine_unregister(sdev, pdata);
> -

I am somewhat surprised that these block on the kernel side rather than
just disconnecting the kernel side of whatever userspace sees - I'd
thought they were more like hotplug operations than something blocking.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux