On Mon, Dec 05, 2022 at 11:36:40PM +0800, Dawei Li wrote:
> Commit fc7a6209d571 ("bus: Make remove callback return
> void") forces bus_type::remove be void-returned, it doesn't
> make much sense for any bus based driver implementing remove
> callbalk to return non-void to its caller.
>
> This change is for macio bus based drivers.
>
> Signed-off-by: Dawei Li <set_pte_at@xxxxxxxxxxx>
> ---
> arch/powerpc/include/asm/macio.h | 12 ++++++------
> drivers/ata/pata_macio.c | 4 +---
> drivers/macintosh/rack-meter.c | 4 +---
> drivers/net/ethernet/apple/bmac.c | 4 +---
> drivers/net/ethernet/apple/mace.c | 4 +---
> drivers/net/wireless/intersil/orinoco/airport.c | 4 +---
> drivers/scsi/mac53c94.c | 5 +----
> drivers/scsi/mesh.c | 5 +----
> drivers/tty/serial/pmac_zilog.c | 7 ++-----
> sound/aoa/soundbus/i2sbus/core.c | 4 +---
> 10 files changed, 16 insertions(+), 37 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/macio.h b/arch/powerpc/include/asm/macio.h
> index ff5fd82d9ff0..f641c730c3b7 100644
> --- a/arch/powerpc/include/asm/macio.h
> +++ b/arch/powerpc/include/asm/macio.h
> @@ -124,15 +124,15 @@ static inline struct pci_dev *macio_get_pci_dev(struct macio_dev *mdev)
> */
> struct macio_driver
> {
> - int (*probe)(struct macio_dev* dev, const struct of_device_id *match);
> - int (*remove)(struct macio_dev* dev);
> + int (*probe)(struct macio_dev *dev, const struct of_device_id *match);
> + void (*remove)(struct macio_dev *dev);
Again, you are changing lines you do not need to here.
thanks,
greg k-h
