Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Chromeos Kdump <chromeos-kdump@xxxxxxxxxx>, Daniel Baluta <daniel.baluta@xxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Len Brown <len.brown@xxxxxxxxx>, Ard Biesheuvel <ardb@xxxxxxxxxx>, Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Eric Biederman <ebiederm@xxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>, Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, x86@xxxxxxxxxx
Subject: Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace
From: Oliver Neukum <oneukum@xxxxxxxx>
Date: Thu, 1 Dec 2022 13:28:50 +0100
Cc: alsa-devel@xxxxxxxxxxxxxxxx, linux-efi@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, kexec@xxxxxxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, sound-open-firmware@xxxxxxxxxxxxxxxx
In-reply-to: <20221127-snd-freeze-v8-3-3bc02d09f2ce@chromium.org>
References: <20221127-snd-freeze-v8-0-3bc02d09f2ce@chromium.org> <20221127-snd-freeze-v8-3-3bc02d09f2ce@chromium.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2

On 01.12.22 12:08, Ricardo Ribalda wrote:

If we are shutting down due to kexec and the userspace is frozen, the
system will stall forever waiting for userspace to complete.

Do not wait for the clients to complete in that case.


Hi,

I am afraid I have to state that this approach is bad in every case,
not just this corner case. It basically means that user space can stall
the kernel for an arbitrary amount of time. And we cannot have that.

	Regards
		Oliver

Follow-Ups:
- Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace
  - From: Ricardo Ribalda

References:
- [PATCH v8 0/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace
  - From: Ricardo Ribalda
- [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace
  - From: Ricardo Ribalda

Prev by Date: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace
Next by Date: Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace
Previous by thread: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace
Next by thread: Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace
Index(es):
- Date
- Thread

[Index of Archives] [ALSA User] [Linux Audio Users] [Pulse Audio] [Kernel Archive] [Asterisk PBX] [Photo Sharing] [Linux Sound] [Video 4 Linux] [Gimp] [Yosemite News]