Hi, On Mon, Nov 28, 2022 at 4:16 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > sc7180_lpass_dev_resume() logs an error if clk_bulk_prepare_enable() > fails. The clock framework already generates error logs if anything > goes wrong, so the logging in _resume() is redundant, drop it. > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > --- > > Changes in v2: > - removed the log in the error path (requested by Doug) > - updated subject (was "ASoC: qcom: lpass-sc7180: Return 0 instead > of 'ret' at the end of _resume()") and commit message > > sound/soc/qcom/lpass-sc7180.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>