Re: [PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Czarek, trying to re-send that mail from my workstation since email client on my phone didn't cc properly.

No, I've got no idea why it's been duplicated. It's my first time contributing to mainline, so sorry about that. Will double-check my patches in the future.

On 22/11/2022 19:10, Cezary Rojewski wrote:
> On 2022-11-22 12:20 AM, Alicja Michalska wrote:
>> KBL platform is missing the definition of 'max98357a' audio amplifier.
>> This amplifier is used on many KBL Chromebooks, for instance variant
>> 'nami' of 'Google/poppy' baseboard.
>>
>> Reported-by: CoolStar <coolstarorganization@xxxxxxxxx>
>> Signed-off-by: Alicja Michalska <ahplka19@xxxxxxxxx>
>>
>> diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c
>> index 87f9c18be238..650faebb33ef 100644
>> --- a/sound/soc/intel/avs/board_selection.c
>> +++ b/sound/soc/intel/avs/board_selection.c
>> @@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
>>           },
>>           .tplg_filename = "max98373-tplg.bin",
>>       },
>> +    {
>> +        .id = "MX98357A",
>> +        .drv_name = "avs_max98357a",
>> +        .mach_params = {
>> +            .i2s_link_mask = AVS_SSP(0),
>> +        },
>> +        .tplg_filename = "max98357a-tplg.bin",
>> +    },
>>       {
>>           .id = "DLGS7219",
>>           .drv_name = "avs_da7219",
>> ---
>>   sound/soc/intel/avs/board_selection.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c
>> index 87f9c18be238..650faebb33ef 100644
>> --- a/sound/soc/intel/avs/board_selection.c
>> +++ b/sound/soc/intel/avs/board_selection.c
>> @@ -129,6 +129,14 @@ static struct snd_soc_acpi_mach avs_kbl_i2s_machines[] = {
>>           },
>>           .tplg_filename = "max98373-tplg.bin",
>>       },
>> +    {
>> +        .id = "MX98357A",
>> +        .drv_name = "avs_max98357a",
>> +        .mach_params = {
>> +            .i2s_link_mask = AVS_SSP(0),
>> +        },
>> +        .tplg_filename = "max98357a-tplg.bin",
>> +    },
>>       {
>>           .id = "DLGS7219",
>>           .drv_name = "avs_da7219",
>
>
> Any reason why diff is repeated twice? It seems that the first copy of diff is part of the commit message.




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux