Re: [PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022-11-22 1:36 AM, Curtis Malainey wrote:
On Mon, Nov 21, 2022 at 3:20 PM Alicja Michalska <ahplka19@xxxxxxxxx> wrote:

KBL platform is missing the definition of 'max98357a' audio amplifier.
This amplifier is used on many KBL Chromebooks, for instance variant
'nami' of 'Google/poppy' baseboard.

Nami isn't a production device, it was a design, I think you mean "Nautilus"

         },
+       {
+               .id = "MX98357A",
+               .drv_name = "avs_max98357a",
+               .mach_params = {
+                       .i2s_link_mask = AVS_SSP(0),
+               },
+               .tplg_filename = "max98357a-tplg.bin",
+       },

Cezary/Lukasz did we check nautilus? From what I can see in coreboot
it should need this.

A bit surprised this entry was not there to begin with.

We have checked several dozen of configurations but I admit, don't remember if this concrete one was. Max98357a was first launched with APL with the avs-driver, then we moved on to Chell and Lars. As I'm not aware of any differences, this should work out of the box with the entry appended.


Regards,
Czarek



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux