On Thu, Nov 17, 2022 at 02:12:48PM +0800, Gaosheng Cui wrote: > Smatch report warning as follows: > > sound/soc/amd/acp/acp-platform.c:199 acp_dma_open() warn: > '&stream->list' not removed from list > > If snd_pcm_hw_constraint_integer() fails in acp_dma_open(), > stream will be freed, but stream->list will not be removed from > adata->stream_list, then list traversal may cause UAF. Is it not better to only add the newly allocated stream to the list once it's fully initialised? Otherwise something could be using a partially initialised item from the list.
Attachment:
signature.asc
Description: PGP signature
