At Sun, 15 Jun 2008 19:26:53 +0200, Krzysztof Helt wrote: > > On Sun, 15 Jun 2008 18:07:02 +0200 > Rene Herman <rene.herman@xxxxxxxxxxxx> wrote: > > > On 15-06-08 12:41, Krzysztof Helt wrote: > > > > > This patch is a start combining ad1848_lib and cs4231_lib > > > functionality. My approach is to make the cs4231_lib module > > > use the ad1848_lib module. This should allow removing > > > most of identical functions from the cs4231_lib and use > > > the functions from the ad1848_lib directly. > > > > > > If this approach is not a good idea, please drop the patch. > > > > > > My current plan is to reuse the ad1848 register constants > > > in the cs423x code and remove duplicated cs4231 constants. > > > This should make the ad1848_lib and cs4231_lib easier to > > > compare for differences. > > > > > > The next step is to use the snd_cs4231 structure instead of > > > the snd_ad1848 structure inside the ad1848_lib. This will make > > > functions from the ad1848_lib taking the same arguments > > > as the functions in the cs4231_lib. > > > > > > The last step would be to export needed functions from the > > > ad1848_lib and use them directly in the cs4231_lib. > > > > > > This should reduce the size of the cs4231_lib while preserving > > > smaller the ad1848_lib for driver which uses only ad1848 > > > functionality. > > > > I believe it would be going a bit overboard to actually make these two > > dependent libs. Unification would seem a good plan probably but as far > > as I'm concerned one lib to drive all these chips should do really. > > > > It can be done this way as well. > > > (*) perhaps under sound/drivers/wss, or sound/isa/lib/wss (or if you > > don't care for the wss name, something else; the location is more the > > point). > > > > I like the wss name. > > Takashi, please drop my patches. If the ad1848 and cs4231 should be unified > a correct way is to use cs4231 structures and constants in the ad1848 library. > Then it will be easy to merge them. OK, it makes sense. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
