Re: [PATCH] Fix tas2562 volume table values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sorry,
maybe outlook is doing some weird things. I will try again with send-email as suggested.

Best regards

Obtener Outlook para Android<https://aka.ms/AAb9ysg>

________________________________
De: Mark Brown <broonie@xxxxxxxxxx>
Enviado: jueves, 3 de noviembre de 2022 14:24
Para: Juan Alfonso Reyes Ajenjo <jareyes@xxxxxxx>
CC: Liam Girdwood <lgirdwood@xxxxxxxxx>; Jaroslav Kysela <perex@xxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; "Martin Povišer" <povik+lin@xxxxxxxxxxx>; Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>; Fabio Estevam <festevam@xxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx <alsa-devel@xxxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; Gustavo Plaza Roma <gplaza@xxxxxxx>
Asunto: Re: [PATCH] Fix tas2562 volume table values

On Thu, Nov 03, 2022 at 01:03:01PM +0000, Juan Alfonso Reyes Ajenjo wrote:
> This patch fixes -90dB value (0x84a3 instead of 0x695b)
> This patch adds missing -20dB value (0x06666666)
> float_vol_db_lookup must have 56 values as volume is from 0 to 55 (0-110dB)
>
> Signed-off-by: Juan Alfonso Reyes Ajenjo jareyes@xxxxxxx<mailto:jareyes@xxxxxxx>
> Signed-off-by: Gustavo Plaza Roma gplaza@xxxxxxx<mailto:gplaza@xxxxxxx>

It looks like this got mangled a bit by your mail client - the signoffs
are rather confused and...

> static const unsigned int float_vol_db_lookup[] = {
> 0x00000d43, 0x000010b2, 0x00001505, 0x00001a67, 0x00002151,
> 0x000029f1, 0x000034cd, 0x00004279, 0x000053af, 0x0000695b,
> -0x0000695b, 0x0000a6fa, 0x0000d236, 0x000108a4, 0x00014d2a,
> +0x000084a3, 0x0000a6fa, 0x0000d236, 0x000108a4, 0x00014d2a,
> 0x0001a36e, 0x00021008, 0x000298c0, 0x000344df, 0x00041d8f,

...there's what looks like a lot of whitespace damage which means the
tooling won't be able to understand it. I usually recommend git
send-email for sending patches, it will avoid most issues.

Also I'd expect Juan's signoff to be last if it's him sending the patch
(possibly Gustavo should be a Co-developed-by or something?).





[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux