Re: [PATCH v2 1/2] ASoC: rt5514: fix legacy dai naming

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 03 Nov 2022 14:21:37 +0100,
Takashi Iwai wrote:
> 
> On Thu, 03 Nov 2022 14:11:43 +0100,
> Jason Montleon wrote:
> > 
> > Starting with 6.0-rc1 these messages are logged and the sound card
> > is unavailable. Adding legacy_dai_naming to the rt5514-spi causes
> > it to function properly again.
> > 
> > [   16.928454] kbl_r5514_5663_max kbl_r5514_5663_max: ASoC: CPU DAI
> > spi-PRP0001:00 not registered
> > [   16.928561] platform kbl_r5514_5663_max: deferred probe pending
> 
> Please avoid hanging on the existing thread if you resubmit a new
> patch set.
> 
> Also, more importantly, your Signed-off-by tag is missing.  It's a
> legal requirement.
> 
> At the next time, run scripts/checkpatch.pl before the submission.
> It'll catch such errors.

Also, it's better to have a few more things in the patches:
- Fixes tag indicating the buggy commit to be fixed
- Link (or BugLink tag) to pointing to the kernel bugzilla URL
- Cc-to-stable tag, to assure the fix going to 6.0.y stable tree


Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux