Thanks for your time.
On 10/28/22 16:28, Mark Brown wrote:
+static int tdm_mode = 0;
+module_param_named(tdm_mode, tdm_mode, int, 0444);
+MODULE_PARM_DESC(tdm_mode, "Set 1 for tdm mode, set 0 for i2s mode");
Why is this a module parameter - how would a user decide to set this?
Is it something that someone might want to change at runtime?
While inserting this module we need to pass tdm_mode variable as 0 or 1
like below.
sudo insmod /lib/modules/$(uname
-r)/kernel/sound/soc/amd/acp/snd-acp-mach.ko *tdm_mode=1*
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
Sorry for the mistake, we will not repeat this.
Thanks.
