Re: [PATCH] ASoC: sof_es8336: reduce pop noise on speaker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 27, 2022 at 03:38:07PM +0800, Zhu Ning wrote:

> +	case SNDRV_PCM_TRIGGER_SUSPEND:
> +	case SNDRV_PCM_TRIGGER_STOP:
> +		if (priv->speaker_en == false)
> +			if (substream->stream == 0)
> +				gpiod_set_value_cansleep(priv->gpio_speakers, true);

What happens if the stream is very briefly started or the system is
heavily loaded and the delayed work hasn't run yet?  We should probably
cancel the work here just to be safe.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux