Hi Aidan > The "convert-xxx" properties only have an effect for DPCM DAI links. > A DAI link is only created as DPCM if the device tree requires it; > part of this involves checking for the use of "convert-xxx" properties. > > When the convert-sample-format property was added, the checks got out > of sync. A DAI link that specified only convert-sample-format but did > not pass any of the other DPCM checks would not go into DPCM mode and > the convert-sample-format property would be silently ignored. > > Fix this by adding a function to do the "convert-xxx" property checks, > instead of open-coding it in simple-card and audio-graph-card. And add > "convert-sample-format" to the check function so that DAI links using > it will be initialized correctly. > > Fixes: 047a05366f4b ("ASoC: simple-card-utils: Fixup DAI sample format") > Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@xxxxxxxxx> > --- (snip) > +bool asoc_simple_convert_is_required(const struct asoc_simple_data *data); This is not a big deal, but "is_conert_required" is better for me :) Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> Thank you for your help !! Best regards --- Kuninori Morimoto