On Fri, Oct 14, 2022 at 10:52:54AM +0200, Benjamin Marty wrote:
> diff --git a/sound/soc/codecs/nau8822.c b/sound/soc/codecs/nau8822.c
> index 1aef281a9972..812b8254f9a0 100644
> --- a/sound/soc/codecs/nau8822.c
> +++ b/sound/soc/codecs/nau8822.c
> @@ -379,6 +379,12 @@ static const struct snd_kcontrol_new nau8822_snd_controls[] = {
> NAU8822_REG_DAC_CONTROL, 5, 1, 0),
> SOC_SINGLE("ADC 128x Oversampling Switch",
> NAU8822_REG_ADC_CONTROL, 5, 1, 0),
<snip>
> + SOC_SINGLE("Speaker BTL Configuration",
> + NAU8822_REG_RIGHT_SPEAKER_CONTROL, 4, 1, 0),
We proposed the exact same change and it was not considered fine [1],
this is considered a system property and should be configured from
something like a device tree.
I would appreciate if you could add me in cc on any follow-up patch on
that, thanks.
Francesco
[1] https://lore.kernel.org/all/20220207153229.1285574-1-francesco.dolcini@xxxxxxxxxxx/
