On 01/10/2022 22:00, Doug Brown wrote: > Create a simple DT schema for the existing Wolfson WM8961 driver so that > DT support can be added to the driver. > > Signed-off-by: Doug Brown <doug@xxxxxxxxxxxxx> > --- > .../devicetree/bindings/sound/wlf,wm8961.yaml | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8961.yaml > > diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8961.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8961.yaml > new file mode 100644 > index 000000000000..73166cf0fdcf > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/wlf,wm8961.yaml > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/wlf,wm8961.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Wolfson WM8961 Ultra-Low Power Stereo CODEC > + > +maintainers: > + - patches@xxxxxxxxxxxxxxxxxxxxx > + > +properties: > + '#sound-dai-cells': > + const: 0 > + > + compatible: > + const: wlf,wm8961 Please put compatible first in list of properties (and follow same order in "required"). It's the most important piece, so we want it to be the first to see. It also follows the convention of DTS, where compatible is expected to be first. > + > + reg: > + maxItems: 1 > + > +required: > + - '#sound-dai-cells' > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + wm8961: codec@4a { > + #sound-dai-cells = <0>; > + compatible = "wlf,wm8961"; Here compatible first, reg second, then the rest. > + reg = <0x4a>; > + }; > + }; Best regards, Krzysztof
