On Mon, Sep 26, 2022 at 02:48:32PM -0500, Rob Herring wrote:
> On Tue, Sep 20, 2022 at 03:26:44PM +0200, Pali Rohár wrote:
> > From: Marcin Wojtas <mw@xxxxxxxxxxxx>
> >
> > The audio unit of Marvell Armada38x SoC is similar to the ones comprised by
> > other Marvell SoCs (Kirkwood, Dove and Armada 370). Therefore KW audio
> > driver can be used to support it and this commit adds new compatible string
> > to identify Armada 38x variant.
> >
> > Two new memory regions are added: first one for PLL configuration and
> > the second one for choosing one of audio I/O modes (I2S or S/PDIF).
> > For the latter purpose a new optional DT property is added ('spdif-mode').
> >
> > kirkwood-i2s driver is extended by adding a new init function for Armada
> > 38x flavor and also a routine that enables PLL output (i.e. MCLK)
> > configuration.
> >
> > Signed-off-by: Marcin Wojtas <mw@xxxxxxxxxxxx>
> > Tested-by: Star_Automation <star@xxxxxxxxxxx>
> > Reviewed-by: Nadav Haklai <nadavh@xxxxxxxxxxx>
> > Reviewed-by: Lior Amsalem <alior@xxxxxxxxxxx>
> > Tested-by: Lior Amsalem <alior@xxxxxxxxxxx>
> > Signed-off-by: Hezi Shahmoon <hezi@xxxxxxxxxxx>
> > Reviewed-by: Neta Zur Hershkovits <neta@xxxxxxxxxxx>
> > [pali: Fix support for pre-38x SoCs]
> > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>
> > ---
> > .../devicetree/bindings/sound/mvebu-audio.txt | 14 +-
> > sound/soc/kirkwood/kirkwood-i2s.c | 136 +++++++++++++++++-
> > sound/soc/kirkwood/kirkwood.h | 2 +
> > 3 files changed, 149 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/mvebu-audio.txt b/Documentation/devicetree/bindings/sound/mvebu-audio.txt
> > index cb8c07c81ce4..4f5dec5cb3c2 100644
> > --- a/Documentation/devicetree/bindings/sound/mvebu-audio.txt
> > +++ b/Documentation/devicetree/bindings/sound/mvebu-audio.txt
> > @@ -6,9 +6,14 @@ Required properties:
> > "marvell,kirkwood-audio" for Kirkwood platforms
> > "marvell,dove-audio" for Dove platforms
> > "marvell,armada370-audio" for Armada 370 platforms
> > + "marvell,armada-380-audio" for Armada 38x platforms
>
> Perhaps be consistent with the 370 string above it.
Hi Rob
That was something i also considered. But actually, all 380
compatibles use armada-380-FOOBAR. So this is inconsistent with
armada370-audio, but consistent with armada-380 in general.
Andrew
