On Mon, 26 Sep 2022 17:56:15 +0200, Jaroslav Kysela wrote: > > On 26. 09. 22 15:55, Takashi Iwai wrote: > > Hi, > > > > this is a patch set for simplifying the reference to the current PCM > > state by having the local copy in runtime instead of relying on > > runtime->status indirection. This also hardens against the attack by > > modifying the mmapped status record. > > > > The first patch does the basic job in the core PCM side, and the > > second patch flips the PCM status mmap to read-only for hardening, > > while the remaining patches are for drivers to follow the core > > change. > > > > The conversions are straightforward. In most places, it's just > > replacing runtime->status->state with runtime->state. > > > > > > Takashi > > > > === > > > > Takashi Iwai (11): > > ALSA: pcm: Avoid reference to status->state > > ALSA: pcm: Make mmap status read-only > > ALSA: aloop: Replace runtime->status->state reference to > > runtime->state > > ALSA: firewire: Replace runtime->status->state reference to > > runtime->state > > ALSA: hda: Replace runtime->status->state reference to runtime->state > > ALSA: asihpi: Replace runtime->status->state reference to > > runtime->state > > ALSA: usb-audio: Replace runtime->status->state reference to > > runtime->state > > ALSA: usx2y: Replace runtime->status->state reference to > > runtime->state > > ASoC: intel: Replace runtime->status->state reference to > > runtime->state > > ASoC: sh: Replace runtime->status->state reference to runtime->state > > usb: gadget: Replace runtime->status->state reference to > > runtime->state > > Nice cleanup. Perhaps, you may add a note to the second patch that the > status is already mmaped as read-only in alsa-lib for ages. So no > regressions are expected. Makes sense. Will add some text. thanks, Takashi