On 21/09/2022 17:11, Pierre-Louis Bossart wrote: >>>> /** >>>> * slim_stream_unprepare() - Un-prepare a SLIMbus Stream >>>> * >>>> * @stream: instance of slim stream runtime to unprepare >>>> * >>>> * This API will un allocate all the ports and channels associated with >>>> * SLIMbus stream >>> >>> You mean this piece of doc? Indeed looks inaccurate. I'll update it. >> >> Wait, no, this is correct. Please point to what is wrong in kernel doc. >> I don't see it. :( > > the TRIGGER_STOP and TRIGGER_PAUSE_PUSH do the same thing. There is no > specific mapping of disable() to TRIGGER_STOP and unprepare() to > TRIGGER_PAUSE_PUSH as the documentation hints at. Which TRIGGER_STOP and TRIGGER_PAUSE_PUSH? In one specific codec driver? If yes, I don't think Slimbus documentation should care how actual users implement it (e.g. coalesce states). Best regards, Krzysztof
