Re: [PATCH v2 3/4] ALSA: hda: intel-nhlt: add intel_nhlt_ssp_mclk_mask()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 19 Sep 2022 13:53:49 +0200,
Pierre-Louis Bossart wrote:
> 
> SOF topologies hard-code the MCLK used for SSP connections. That was a
> bad idea in hindsight, this information should really come from BIOS
> and/or machine driver.
> 
> This patch introduces a helper to scan all SSP endpoints connected to
> a codec, and all formats to see what MCLK is used. When BIT(0) of the
> mdivc offset if set in the SSP blob, MCLK0 is used, and likewise when
> BIT(1) is set MCLK1 is used.
> 
> The case where both MCLKs are used is possible but has never been seen
> in practice so should be treated as an error by the caller.
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> Reviewed-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>
> Reviewed-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>

Reviewed-by: Takashi Iwai <tiwai@xxxxxxx>


thanks,

Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux