On 15/09/2022 12:39, Astrid Rost wrote: > Add devicetree parameters to control the insertion, release and press > debounce times. > Thank you for your patch. There is something to discuss/improve. > Signed-off-by: Astrid Rost <astrid.rost@xxxxxxxx> > --- > .../devicetree/bindings/sound/ts3a227e.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ts3a227e.yaml > index 3512b1f1e32b..8c27f298733a 100644 > --- a/Documentation/devicetree/bindings/sound/ts3a227e.yaml > +++ b/Documentation/devicetree/bindings/sound/ts3a227e.yaml > @@ -44,6 +44,35 @@ properties: > - 7 # 2.8 V > default: 2 > > + ti,debounce-release-ms: > + description: key release debounce time in ms (datasheet section 9.6.7). > + enum: > + - 0 # 0 ms (0) > + - 20 # 20 ms (1) Skip comments. The values are in ms, so they are not helping. Same in all other places. > + default: 20 Except that looks ok, thanks for the changes. Appreciated! Best regards, Krzysztof
