On 2022/9/13 下午 06:59, Mark Brown wrote:
On Tue, Sep 13, 2022 at 03:25:39PM +0800, AS50 CTLin0 wrote:
OK, maybe I should change property name to "adcout-drive-strong" and the
description to "make the drive strength of ADCOUT IO PIN strong if set.
Otherwise, the drive keeps normal strength.".
That sounds good.
Perhaps adding something like "strong" would be good - with the
name I'd expected the property to be a numerical strength rather
than a boolean.
From our design, the register just have one bit for this feature, so
the strength just have normal or stronger. Therefore, I use boolean
property for it.
Using a boolean property is fine, it just feels weird that it
doesn't say specifically what "stronger" means here. I was just
thinking adding a note in the description but either way it's not
essential.
Thanks for your review. It will make the patch more clearly.
I will refine it and send new patches for review.
________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
