Re: [PATCH] ASoC: meson: aiu-fifo.c: use devm_kzalloc(), and remove .remove function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jerome, Mark

> > > Current aiu-fifo.c is using kzalloc()/kfree(), but we can replace
> > > it by devm_kzalloc(), and remove kfree().
> > > This patch do it.
> 
> > I'm not sure about this change Kuninori.
> 
> > This is the dai probe, not the device driver probe.
> > If I'm not mistaken it gets called when binding the card.
> 
> > The components and card drivers are different here.
> 
> > If the card probes several times for any reason, EPROBE_DEFER for
> > example, wouldn't this allocate the memory several times without
> > releasing it ?
> 
> Yes, indeed.  You'd need to move the allocation to the device level
> probe to convert to devm (which *would* be a good thing to do if
> possible).

Oh, yes, indeed.
I will fixup it in v2.

Thank you for your help !!

Best regards
---
Kuninori Morimoto



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux