On Fri, Sep 09, 2022 at 02:54:34AM +0000, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > This patch fixup this warning > > linux/sound/soc/codecs/ak4458.c:631:13: error: 'ak4458_reset' defined but\ > not used [-Werror=unused-function] > 631 | static void ak4458_reset(struct ak4458_priv *ak4458, bool active) > | ^~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Fixes: e9e7df88996d64 ("ASoC: ak4458: Remove component probe() and remove()") Is this the best fix, or should we be adding _reset() calls into the device level probe() and remove() functions? Actually I'm not sure the driver works without CONFIG_PM since the probe isn't powering on the device but then that's not a super realistic use case anyway.
Attachment:
signature.asc
Description: PGP signature