Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> 于2022年8月31日周三 01:35写道： > On 30/08/2022 18:07, Ban Tao wrote: > > DT binding documentation for this new ASoC driver. > > Thank you for your patch. There is something to discuss/improve. > > > > > > .../bindings/sound/allwinner,sun50i-h6-dmic.yaml | 79 > ++++++++++++++++++++++ > > 1 file changed, 79 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml > > > > diff --git > a/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml > b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml > > new file mode 100644 > > index 0000000..0cfc07f > > --- /dev/null > > +++ > b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml > > @@ -0,0 +1,79 @@ > > +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/allwinner,sun50i-h6-dmic.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Allwinner H6 DMIC Device Tree Bindings > > s/Device Tree Bindings// > So, modify it to 'Allwinner H6 DMIC Devices Tree Bindings', sure? > > > + > > +maintainers: > > + - Ban Tao <fengzheng923@xxxxxxxxx> > > + > > +properties: > > + "#sound-dai-cells": > > + const: 0 > > + > > + compatible: > > + const: allwinner,sun50i-h6-dmic > > Put compatible first in the list of properties (also in required:). > > Rest is ok, so keep the Rb-tags you already got. > > Best regards, > Krzysztof >
