Re: [PATCH 4/5] ASoC: fsl: fsl-utils: remove useless assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 23, 2022 at 2:43 AM Pierre-Louis Bossart <
pierre-louis.bossart@xxxxxxxxxxxxxxx> wrote:

> cppcheck warning:
>
> sound/soc/fsl/fsl_utils.c:127:10: style: Variable 'ret' is assigned a
> value that is never used. [unreadVariable]
>  int ret = 0;
>          ^
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> Reviewed-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
> Reviewed-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>
> Reviewed-by: Chao Song <chao.song@xxxxxxxxx>
>

Acked-by: Shengjiu Wang <shengjiu.wang@xxxxxxxxx>

Best regards
Wang Shengjiu

> ---
>  sound/soc/fsl/fsl_utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_utils.c b/sound/soc/fsl/fsl_utils.c
> index d0fc430f7033d..a5ab27c2f711c 100644
> --- a/sound/soc/fsl/fsl_utils.c
> +++ b/sound/soc/fsl/fsl_utils.c
> @@ -124,7 +124,7 @@ void fsl_asoc_reparent_pll_clocks(struct device *dev,
> struct clk *clk,
>  {
>         struct clk *p, *pll = NULL, *npll = NULL;
>         bool reparent = false;
> -       int ret = 0;
> +       int ret;
>
>         if (!clk || !pll8k_clk || !pll11k_clk)
>                 return;
> --
> 2.34.1
>
>



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux