On Tue, 16 Aug 2022 13:17:21 +0200, Cezary Rojewski wrote: > > A follow up to the recent HDAudio fixes series [1]. Given the recently > reported regression [2], before the page fault occurring on codec > shutdown can be fixed, codec construction procedure needs to be updated > for skylake and sof-intel drivers. Drivers: pci-hda and avs need no > changes - already making use of snd_hda_codec_device_init(). > > As subject touches code used by the sof-driver, additional review has > been conducted on thesofproject/linux [3]. > > Changes in v2: > > - dropped snd_hda_ext_core <-> snd_hda_codec dependency by calling > snd_hda_codec_device_init() directly in skylake and sof drivers probe > enumeration routines, as suggested by Takashi > - skylake/sof portion of the change has been split into two separate > patches > > - new functions that aim to replace hdac_ext codec init & exit > functionality are added first - for skylake and sof drivers both > - third patch in the series now combines the "field -> pointer" change > for hdac_hda_priv->codec plus the codec-enumeration adjustments for > skylake and sof drivers > Both above are here to keep git bisect happy, as suggested by Pierre > > [1]: https://lore.kernel.org/alsa-devel/20220706120230.427296-7-cezary.rojewski@xxxxxxxxx/ > [2]: https://lore.kernel.org/alsa-devel/3c40df55-3aee-1e08-493b-7b30cd84dc00@xxxxxxxxxxxxxxx/ > [3]: https://github.com/thesofproject/linux/pull/3775 > > Cezary Rojewski (6): > ASoC: Intel: Skylake: Introduce HDA codec init and exit routines > ASoC: SOF: Intel: Introduce HDA codec init and exit routines > ASoC: Intel: Drop hdac_ext usage for codec device creation > ALSA: hda: Always free codec on the device release > ALSA: hda: Remove codec init and exit routines > ALSA: hda: Fix page fault in snd_hda_codec_shutdown() Applied all patches now to for-next branch. Thanks. Takashi