On Tue, 16 Aug 2022 02:44:27 +0200, mbarriolinares wrote: > > > Hi all, > > > > I believe these are the right emails to send this patch to, > > but if I've missed something please let me know. > > > > This patch enables the Avid Mbox 3 audio interface to > > be used through ALSA. It locks the device at a 48khz sample rate. > > Then it mutes and raises the appropriate channels/inputs to allow > > for expected functionality. > > > > Thanks for your time. > > Thanks Conner for taking the time to write and submit this! > > I have an MBox 3 (USB) and I've tested the patch: > > 1. Have not tested S/PDIF i/o because I don't have hardware to plug it. > 2. Output is in mono. It seems the monitor outputs work only in MONO. > (with and without the front mono button switched on or off). > 3. Haven't tested if Headphones output work in stereo because I don't > have hardware for testing. > 3. Inputs work great. > > I'll get a stereo 1/4'' jack to 3.5mm for testing the headphones out. > You can contact me directly if needed. It seems that I overlooked this patch some how. Through a quick glance, the patch needs the proper Signed-off-by line, at least, for merging to the upstream. Also, simple memset() with zero could be used for clearing the com_buf. Otherwise, it's fine to apply as long as the stuff works more or less (at least improving things). thanks, Takashi
