On Thu, 2022-08-04 at 13:41 +0100, Mark Brown wrote:
> On Thu, Aug 04, 2022 at 05:13:59PM +0800, Chunxu Li wrote:
>
> > +static struct snd_sof_of_mach sof_mt8186_machs[] = {
> > + {
> > + .board = "mediatek,mt8186",
> > + .sof_tplg_filename = "sof-mt8186.tplg",
>
> The mediatek,mt8186 compatible looks like a SoC compatible not a
> board
> compatible...
Our dts config as below:
kingler board:
compatible = "google,corsola", "google,kingler", "mediatek,mt8186";
krabby board:
compatible = "google,corsola", "google,krabby", "mediatek,mt8186";
they all use the same sof_tplg_filename, so i use "mediatek,mt8186" to
match these.
The original code looks like the following:
static struct snd_soc_acpi_mach sof_mt8186_machs[] = {
{
.board = "google,kingler",
.sof_tplg_filename = "sof-mt8186.tplg",
},
{
.board = "google,krabby",
.sof_tplg_filename = "sof-mt8186.tplg",
},
{}
};
Which of the two approaches do you prefer?
