On Fri, Jul 29, 2022 at 09:12:17AM -0500, Pierre-Louis Bossart wrote: > > > diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c > > index 893296f3fe39..81c77e6ddbad 100644 > > --- a/drivers/soundwire/bus_type.c > > +++ b/drivers/soundwire/bus_type.c > > @@ -193,6 +193,7 @@ int __sdw_register_driver(struct sdw_driver *drv, struct module *owner) > > > > drv->driver.owner = owner; > > drv->driver.probe = sdw_drv_probe; > > + drv->driver.dev_groups = sdw_attr_groups; > > > > if (drv->remove) > > drv->driver.remove = sdw_drv_remove; > > Minor rebase issue: this version of the bus_type.c code is no longer > up-to-date, this patch creates a conflict with "soundwire: bus_type: fix > remove and shutdown support" merged by Vinod - should be in your > char-misc tree as well for 5.20. Sorry, did this against Linus's tree, I will rebase it against 5.20-rc1 when that comes out and resend it then. thanks, greg k-h