[AMD Official Use Only - General] On 7/22/2022 8:22 PM, Mark Brown wrote: Thanks for your time. On Fri, Jul 22, 2022 at 07:47:03PM +0530, Venkata Prasad Potturu wrote: Update dai_id macros to make code generic for all platforms. -#define I2S_SP_INSTANCE 0x00 -#define I2S_BT_INSTANCE 0x01 -#define DMIC_INSTANCE 0x02 +#define DMIC_INSTANCE 0x00 +#define I2S_SP_INSTANCE 0x01 +#define I2S_BT_INSTANCE 0x02 This looks like it's just an indentation/formatting change which isn't what the changelog said? We are changing dai_id macro numbers, as renoir platform has 2 I2S instances and Rembrandt platform has 3 I2S instances. To make I2S instances as order, change DMIC_INSTANCE to 0x00, I2S_SP_INSTANCE to 0x01 and I2S_BT_INSTANCE to 0x02. I2S_HS_INSTANCE is already 0x03.