On 2022-07-15 8:23 PM, Takashi Iwai wrote:
On Fri, 15 Jul 2022 20:16:14 +0200,
Pierre-Louis Bossart wrote:
...
This patch causes an across-the-board regression on all SOF platforms
using an HDaudio or iDISP codec. Only 'nocodec' platforms are
unaffected, see results at
https://sof-ci.01.org/linuxpr/PR3763/build394/devicetest/
Reverting this commit seems to fix the issue.
Upstream merge:
https://github.com/thesofproject/linux/pull/3763
Issue and bisect results
https://github.com/thesofproject/linux/issues/3764
I don't know what this was supposed to fix on the shutdown path but it's
clearly having side effects on the probe/init path.
Yeah, obviously the patch ignores the fact that hdac_hda does
initialize the HD-audio codec without snd_hda_codec_device_init().
I'm going to revert the commit.
Thanks for the report and sorry the trouble.
This patch is still valid - will re-check hdac_hda.c and update it so
that both the regression and the page fault are gone.
Regards,
Czarek