Re: [PATCH v5] update tas2780.yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 12, 2022 at 01:08:57PM +0800, Raphael-Xu wrote:
> 1.remove unused item in DT 2.revise the format

Again, fix your subject. Run 'git log --oneline 
Documentation/devicetree/bindings/sound/' for inspiration of the format 
of the subject.

However, there's a bigger issue here. We already have a binding for this 
device. It's in tas27xx.yaml. And you added 2780 to it, so why did you 
add another schema? (All the same issues in that patch too. wrong 
subject, broken schema. So you haven't learned.)

And then there is also tas2770.yaml which appears to be about the same 
as well.

> 
> Signed-off-by: Raphael-Xu <13691752556@xxxxxxx>
> ---
>  .../devicetree/bindings/sound/tas2780.yaml    | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux